feat: add renderer pipeline support to manifest generation in#483
Merged
michaeljguarino merged 19 commits intomainfrom Feb 9, 2026
Merged
Conversation
JohnBlackwell
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Member
|
You need to make sure the pr checks pass (its our way of ensuring the code has been tested e2e before merge) |
JohnBlackwell
force-pushed
the
john/prod-3699-add-renderer-pipeline-support-to-manifest-generation-in
branch
from
2fdeb2d to
8967428
Compare
…-to-manifest-generation-in
…-to-manifest-generation-in
…-to-manifest-generation-in
…-to-manifest-generation-in
…-to-manifest-generation-in
…-to-manifest-generation-in
|
|
||
| allManifests = append(allManifests, manifests...) | ||
| slices.Reverse(allManifests) | ||
| allManifests = lo.UniqBy(allManifests, func(item unstructured.Unstructured) string { |
Member
There was a problem hiding this comment.
doing this w/in the loop is going to make the operation O(n^2), you should do it after (and probably only if len(renderers) > 0)
michaeljguarino
approved these changes
Feb 9, 2026
michaeljguarino
deleted the
john/prod-3699-add-renderer-pipeline-support-to-manifest-generation-in
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan
Test environment: https://console.plrl-dev-aws.onplural.sh/
Checklist